Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingredient by role block level helper #2180

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 20, 2021

What is this pull request for?

Add ingredient_by_role element block helper

The ingredient equivalent to el.essence and el.content

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 6.0 milestone Aug 20, 2021
@tvdeyen tvdeyen requested a review from a team August 20, 2021 10:21
Copy link
Contributor

@robinboening robinboening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this!

I just left a non-blocking question.

@robinboening
Copy link
Contributor

Just noticed one Job on CI did not succeed. The reason was a Segfault, so I think re-running might just solve the problem.

@tvdeyen
Copy link
Member Author

tvdeyen commented Aug 20, 2021

Just noticed one Job on CI did not succeed. The reason was a Segfault, so I think re-running might just solve the problem.

Yes. Unfortunately GitHub still does not allow to re-run a single job. Since this fail is not related to this PR and we do not want to waste too much energy and resources we can just merge it.

@tvdeyen tvdeyen merged commit 81a1d5a into AlchemyCMS:main Aug 20, 2021
@tvdeyen tvdeyen deleted the ingredient_by_role-block-level-helper branch August 20, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants